comnetwork commented on code in PR #4756:
URL: https://github.com/apache/hbase/pull/4756#discussion_r1002478326
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java:
##########
@@ -255,15 +255,21 @@ private void dequeueCurrentLog() throws IOException {
* Returns whether the file is opened for writing.
*/
private boolean readNextEntryAndRecordReaderPosition() throws IOException {
+ long prePos = reader.getPosition();
Review Comment:
> One of our customers seems to be consistently reaching this EOF problem,
per below exception trace.
>
> `WARN org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader:
Encountered a malformed edit, seeking back to last good position in file, from
31912404 to 31912265 java.io.EOFException: EOF while reading 106 WAL KVs;
started reading at 31912338 and read up to 31912404 at
org.apache.hadoop.hbase.regionserver.wal.ProtobufLogReader.readNext(ProtobufLogReader.java:397)
at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:98) at
org.apache.hadoop.hbase.regionserver.wal.ReaderBase.next(ReaderBase.java:86) at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.readNextEntryAndRecordReaderPosition(WALEntryStream.java:262)
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.tryAdvanceEntry(WALEntryStream.java:176)
at
org.apache.hadoop.hbase.replication.regionserver.WALEntryStream.hasNext(WALEntryStream.java:101)`
@wchevreuil, this problem seems not throw EOFException in
`WALEntryStream.readNextEntryAndRecordReaderPosition`, it may be another
problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
