[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-14 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-13 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-993129730 @Apache9 ,thank you very much for detailed reply, yes, I understand your point, maybe I did not explain clearly. My opinion is that whether we could make the code more

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-06 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-986219358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-06 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-986219358 @Apache9 , thank you very much for review. In my opinion seems that introducing a `DelegateKeyValueScanner` could not solve the problem: 1. It seems a reference

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-06 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-986219358 @Apache9 , thank you very much for review. In my opinion seems that introducing a `DelegateKeyValueScanner` could not solve the problem: 1. It seems a reference

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-06 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-986219358 @apache9,thank you very much for review. In my opinion: 1. It seems a reference count problem , the SnapshotSegmentScanner seems independent of whether snapshot

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-05 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-986219358 @apache9,thank you very much for review. In my opinion: 1. It seems a reference count problem , the SnapshotSegmentScanner seems independent of whether snapshot

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-05 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-986219358 @apache9,thank you very much for review. In my opinion: 1. It seems a reference count problem , the SnapshotSegmentScanner seems independent of whether snapshot

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-05 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-986219358 @apache9,thank you very much for review. In my opinion: 1. It seems a reference count problem , the SnapshotSegmentScanner seems independent of whether snapshot

[GitHub] [hbase] comnetwork edited a comment on pull request #3899: HBASE-26488 Memory leak when MemStore retry flushing

2021-12-05 Thread GitBox
comnetwork edited a comment on pull request #3899: URL: https://github.com/apache/hbase/pull/3899#issuecomment-986219358 @apache9,thank you very much for review. In my opinion: 1. It seems a reference count problem , the SnapshotSegmentScanner seems independent of whether snapshot