[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-05-28 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r432225834 ## File path: hbase-protocol-shaded/src/main/protobuf/server/rsgroup/RSGroupAdmin.proto ## @@ -183,4 +191,7 @@ service RSGroupAdminService { rpc RenameR

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-18 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r442613146 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java ## @@ -114,6 +120,14 @@ public boolean removeServer(Address hostPor

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-19 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r443107302 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -1244,4 +1244,11 @@ public synchronized void renam

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-19 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r443107712 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManager.java ## @@ -114,4 +115,12 @@ static RSGroupInfoManager create(Mas

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-21 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r443204710 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java ## @@ -46,6 +49,8 @@ @Deprecated private final SortedSet tabl

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-21 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r443204702 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java ## @@ -114,6 +121,34 @@ public boolean removeServer(Address hostPor

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-21 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r443287764 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java ## @@ -114,6 +121,34 @@ public boolean removeServer(Address hostPor

[GitHub] [hbase] ddupg commented on a change in pull request #1782: HBASE-24431 RSGroupInfo add configuration map to store something extra

2020-06-21 Thread GitBox
ddupg commented on a change in pull request #1782: URL: https://github.com/apache/hbase/pull/1782#discussion_r443302968 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfo.java ## @@ -114,6 +121,34 @@ public boolean removeServer(Address hostPor