[GitHub] [hbase] gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

2019-11-07 Thread GitBox
gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#issuecomment-551332896 Test failure doesn't look related: [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 126.

[GitHub] [hbase] gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

2019-11-07 Thread GitBox
gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#issuecomment-551238094 I still think ClassSIze's calculations are slightly wrong, but now they're self-consistent with the self-reported

[GitHub] [hbase] gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

2019-11-06 Thread GitBox
gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#issuecomment-550374432 And looking more closely, it appears that it's just comparing two different estimation methods for the heapsize (o

[GitHub] [hbase] gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

2019-11-05 Thread GitBox
gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#issuecomment-550159469 The checkstyle bugs are trivial and I'll fix them, but I have some questions about the test failure. TestHBlock.te

[GitHub] [hbase] gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

2019-11-05 Thread GitBox
gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#issuecomment-550118691 Fixed the compilation error. Before the original submission I'd fixed a checkstyle issue but lost an import statem