huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-724392322
Hi @Apache9 and @saintstack, please review the changes for branch-2. The
scan over a specific replica region is not supported in branch-2, so I added
ReverseScan over a specif
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-724914478
Seems that the patch has some issue, because related tests are failing, let
me look into those failures.
This
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-725027005
> We do not support scan on a specific replica on branch-2? I think this
should be a bug? We can set replica id on a Scan object?
Actually, it is not mentioned before th
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-725050749
Uploaded a new patch which fixes unitest errors.
This is an automated message from the Apache Git Service.
To
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-725087113
> > > We do not support scan on a specific replica on branch-2? I think this
should be a bug? We can set replica id on a Scan object?
> >
> >
> > Actually, it is not
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-725502657
> Checked the code, we do not support scan on a specific replica... I think
this should be a bug...
>
> Let me open an issue to address it, should not be very hard but t
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-725665381
Pushed addendum to remove setUseMetaReplicas() and updated unittests
accordingly.
@Apache9, once you commit HBASE-25272, I can rebase my patch accordingly.
---
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-725665594
@saintstack, I pushed the diff to remove setUseMetaReplicas(), please
review, thanks.
This is an automated me
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-726239551
HBASE-18070.branch-2 needs to be rebased to include Duo's HBASE-27252. I
rebased my branch and now the review messes up.
-
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-726485274
@Apache9 @saintstack I have rebased my branch to include HBASE-25272, please
review. It shows lots of commits, but please look at the last two commits. Once
Stack rebase HBASE
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-727713700
@saintstack Could you rebase HBASE-18070.branch-2 to latest branch-2? thanks
This is an automated message from
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-728364351
I run TestMetaRegionLocationCache#testStandByMetaLocations and it passed
locally. Probably this test is flakey.
--
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-728365280
@Apache9 @saintstack I think your comments are addressed. Is this patch
good to be merged? Thanks.
This is a
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-730632155
@Apache9 Ping for +1. I think all your comments are addressed, thanks.
This is an automated message from the A
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-730632640
I would assume that you had +1 here, but want to double check with you.
This is an automated message from the
huaxiangsun commented on pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#issuecomment-731316250
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
16 matches
Mail list logo
