[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r446475799 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicyHeterogeneousStorage.java ## @@ -0,0 +1,185 @@

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r446475459 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1564,6 +1568,18 @@ public void

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r446475247 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDateTieredCompactionPolicyHeterogeneousStorage.java ## @@ -0,0 +1,185 @@

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-06-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r446474765 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DateTieredStoreEngine.java ## @@ -94,6 +94,7 @@ public void

[GitHub] [hbase] infraio commented on a change in pull request #1730: HBASE-24289 Heterogeneous Storage for Date Tiered Compaction

2020-05-26 Thread GitBox
infraio commented on a change in pull request #1730: URL: https://github.com/apache/hbase/pull/1730#discussion_r430245575 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java ## @@ -547,6 +553,22 @@ public StoreFileWriter build()