[GitHub] [hbase] meszibalu commented on pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
meszibalu commented on PR #5065: URL: https://github.com/apache/hbase/pull/5065#issuecomment-1448052232 > I agree with covering this with a unit test but I don't see how we can do that. @meszibalu Were you able to verify this change on an HBase cluster? Yes, I validated it. -- This

[GitHub] [hbase] meszibalu commented on pull request #5065: HBASE-27673 Fix mTLS client hostname verification

2023-02-28 Thread via GitHub
meszibalu commented on PR #5065: URL: https://github.com/apache/hbase/pull/5065#issuecomment-1447768627 > Is there any test we can easily add for this case? It's too bad this wasn't caught by tests It requires a test case where we connect to hbase from an IP address which is not loca