[GitHub] [hbase] mosmeh commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-02-28 Thread via GitHub
mosmeh commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1447839824 @Apache9 Here it is: https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mosmeh -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [hbase] mosmeh commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-02-08 Thread via GitHub
mosmeh commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1422391574 @Apache9 @frostruan Let's decide whether we want to keep the old metric information. I personally want to, as I think that is the consistent behavior with HBase 1.x. -- This is an automat

[GitHub] [hbase] mosmeh commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-01-29 Thread via GitHub
mosmeh commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1407593427 You are correct. Updated to clearMetric=false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] mosmeh commented on pull request #4997: HBASE-24781 Clean up peer metrics when disabling peer

2023-01-28 Thread via GitHub
mosmeh commented on PR #4997: URL: https://github.com/apache/hbase/pull/4997#issuecomment-1407357024 Thank you, I was not aware of [HBASE-27463](https://issues.apache.org/jira/browse/HBASE-27463). The PR https://github.com/apache/hbase/pull/4863 does seem to address [HBASE-24781](https://i