[GitHub] [hbase] ndimiduk commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch

ndimiduk commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r459047138 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java ## @@ -85,6 +90,12 @@ public void sync(boolean

[GitHub] [hbase] ndimiduk commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch

ndimiduk commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r452994871 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java ## @@ -231,4 +231,9 @@ protected long

[GitHub] [hbase] ndimiduk commented on a change in pull request #2034: Backport "HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length. (#1970)" to branch

ndimiduk commented on a change in pull request #2034: URL: https://github.com/apache/hbase/pull/2034#discussion_r452529869 ## File path: hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/WrapperAsyncFSOutput.java ## @@ -91,7 +93,11 @@ private void