ndimiduk commented on a change in pull request #3863:
URL: https://github.com/apache/hbase/pull/3863#discussion_r753609492
##########
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncRegionLocatorTracing.java
##########
@@ -90,16 +102,33 @@ public void tearDown() throws IOException {
}
private SpanData waitSpan(String name) {
- Waiter.waitFor(CONF, 1000,
- () -> traceRule.getSpans().stream().map(SpanData::getName).anyMatch(s ->
s.equals(name)));
- return traceRule.getSpans().stream().filter(s ->
s.getName().equals(name)).findFirst().get();
+ return waitSpan(hasName(name));
+ }
+
+ private SpanData waitSpan(Matcher<SpanData> matcher) {
+ Matcher<SpanData> spanLocator = allOf(matcher, hasEnded());
+ try {
+ Waiter.waitFor(CONF, 1000, new MatcherPredicate<>(
+ "waiting for span",
+ () -> traceRule.getSpans(), hasItem(spanLocator)));
+ } catch (AssertionError e) {
+ traceRule.getSpans().forEach(System.err::println);
+ }
+ return traceRule.getSpans()
+ .stream()
+ .filter(spanLocator::matches)
+ .findFirst()
+ .orElseThrow(AssertionError::new);
}
@Test
public void testClearCache() {
conn.getLocator().clearCache();
SpanData span = waitSpan("AsyncRegionLocator.clearCache");
- assertEquals(StatusCode.OK, span.getStatus().getStatusCode());
+ assertThat(span, allOf(
+ hasStatusWithCode(StatusCode.OK),
+ hasKind(SpanKind.CLIENT),
Review comment:
I'm not clear on whether these spans should be "client" or "internal".
Perhaps only the ones that can make an RPC should be "client", the rest left as
"internal".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
