[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323173236 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1697,8 +1722,27 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323158894 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1700,6 +1721,21 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1323068390 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1658,16 +1676,19 @@ private ByteBuff allocate(int size, boolean intoHeap) {

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1322922297 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321749214 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321748184 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1667,7 +1688,11 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321725464 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java: ## @@ -1721,14 +1765,36 @@ protected HFileBlock readBlockDataInternal(FSDataInputStream

[GitHub] [hbase] ndimiduk commented on a diff in pull request #5384: WIP HBASE-28065 Corrupt HFile data is mishandled in several cases

ndimiduk commented on code in PR #5384: URL: https://github.com/apache/hbase/pull/5384#discussion_r1321481778 ## hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockHeaderCorruption.java: ## @@ -0,0 +1,533 @@ +/* + * Licensed to the Apache Software