[GitHub] [hbase] ndimiduk commented on issue #957: HBASE-23604: Clarify AsyncRegistry usage in the code.

2020-01-03 Thread GitBox
ndimiduk commented on issue #957: HBASE-23604: Clarify AsyncRegistry usage in the code. URL: https://github.com/apache/hbase/pull/957#issuecomment-570639921 From [patch-unit-hbase-server.txt](https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-957/5/artifact/out/patch-unit-hbase

[GitHub] [hbase] ndimiduk commented on issue #957: HBASE-23604: Clarify AsyncRegistry usage in the code.

2020-01-03 Thread GitBox
ndimiduk commented on issue #957: HBASE-23604: Clarify AsyncRegistry usage in the code. URL: https://github.com/apache/hbase/pull/957#issuecomment-570639097 @bharathv `TestZooKeeperTableArchiveClient` fails consistently for me. Looks like it's built around a mock registry instance. Mind ta

[GitHub] [hbase] ndimiduk commented on issue #957: HBASE-23604: Clarify AsyncRegistry usage in the code.

2020-01-03 Thread GitBox
ndimiduk commented on issue #957: HBASE-23604: Clarify AsyncRegistry usage in the code. URL: https://github.com/apache/hbase/pull/957#issuecomment-570634067 @virajjasani you have anything to add here? This is an automated mes

[GitHub] [hbase] ndimiduk commented on issue #957: HBASE-23604: Clarify AsyncRegistry usage in the code.

2020-01-02 Thread GitBox
ndimiduk commented on issue #957: HBASE-23604: Clarify AsyncRegistry usage in the code. URL: https://github.com/apache/hbase/pull/957#issuecomment-570308068 Thank you for making an effort to improve this class name. I also find it confusing for a first-read experience. ---