[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005192587 I'm pretty sure this will not work with today's version of JDK11 ; we appear to be blocked by [JDK-8214165](https://bugs.openjdk.java.net/browse/JDK-8214165). -- This is an

[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005103719 It's never as simple as that... ``` $ env JAVA_HOME=/Library/Java/JavaVirtualMachines/adoptopenjdk-11.jdk/Contents/Home mvn clean install assembly:single -DskipTests

[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2022-01-04 Thread GitBox
ndimiduk commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-1005094596 > > Perhaps the change to `create-release` can be done in isolation to the change to the pom. > > Yes, let's have separated issues for these two changes. The

[GitHub] [hbase] ndimiduk commented on pull request #3974: HBASE-25465 Use javac --release option for supporting cross version compilation in create-release

2021-12-22 Thread GitBox
ndimiduk commented on pull request #3974: URL: https://github.com/apache/hbase/pull/3974#issuecomment-64413 Perhaps the change to `create-release` can be done in isolation to the change to the pom. -- This is an automated message from the Apache Git Service. To respond to the