[GitHub] [hbase] nyl3532016 commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-08-06 Thread GitBox
nyl3532016 commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-669848165 @saintstack please have a look, thanks This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] nyl3532016 commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-31 Thread GitBox
nyl3532016 commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-667476083 > Let's run a YCSB or at least a PE to see the performance impact? @Apache9 sir,I have done the performance test, and attaches on jira page, please take a look ?

[GitHub] [hbase] nyl3532016 commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-12 Thread GitBox
nyl3532016 commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-657196375 > Let's run a YCSB or at least a PE to see the performance impact? yes,it is necessary, Let me do it

[GitHub] [hbase] nyl3532016 commented on pull request #2018: HBASE-24659 Calculate FIXED_OVERHEAD automatically

2020-07-12 Thread GitBox
nyl3532016 commented on pull request #2018: URL: https://github.com/apache/hbase/pull/2018#issuecomment-657186954 > I wonder do we still need the testSizes method in TestHeapSize after this change? And we need a performance test to see if there are any impact on performance(although I