[GitHub] [hbase] nyl3532016 commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-11 Thread GitBox
nyl3532016 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-671906297 [#2231](https://github.com/apache/hbase/pull/2231) has resolved this issue, close this PR This is an automated

[GitHub] [hbase] nyl3532016 commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
nyl3532016 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-671005863 > Do you think using default UncaughtExceptionHandler will provide better warn logs if something goes wrong with relogin()? Maybe try creating a custom UncaughtExceptionHandler

[GitHub] [hbase] nyl3532016 commented on pull request #2206: HBASE-24825 Add UncaughtExceptionHandler for NettyRpcConnection Relogin thread

2020-08-08 Thread GitBox
nyl3532016 commented on pull request #2206: URL: https://github.com/apache/hbase/pull/2206#issuecomment-670934971 @virajjasani when submitting this patch, I find maybe the default UncaughtExceptionHandler (Threads.LOGGING_EXCEPTION_HANDLER) will unset in ThreadFactoryBuilder.dobuild afte