[GitHub] [hbase] nyl3532016 commented on pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-18 Thread GitBox
nyl3532016 commented on pull request #2250: URL: https://github.com/apache/hbase/pull/2250#issuecomment-675803464 Thanks for review @huaxiangsun This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] nyl3532016 commented on pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-16 Thread GitBox
nyl3532016 commented on pull request #2250: URL: https://github.com/apache/hbase/pull/2250#issuecomment-674510116 @huaxiangsun mind help review this PR? This is an automated message from the Apache Git Service. To respond to

[GitHub] [hbase] nyl3532016 commented on pull request #2250: HBASE-24872 refactor valueOf PoolType

2020-08-12 Thread GitBox
nyl3532016 commented on pull request #2250: URL: https://github.com/apache/hbase/pull/2250#issuecomment-673228584 > Can you explain a bit more about > `since Reusable PoolType has been removed, no need to check allowedPoolTypes`? Went through the patch, still not clear about the