[GitHub] [hbase] saintstack commented on issue #995: HBASE-23055 Alter hbase:meta

2020-01-09 Thread GitBox
saintstack commented on issue #995: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/995#issuecomment-572677533 Merged manually to branch-2 + after fixing single checkstyle complaint above about unused import. Thanks for reviews @bharathv . ---

[GitHub] [hbase] saintstack commented on issue #995: HBASE-23055 Alter hbase:meta

2020-01-08 Thread GitBox
saintstack commented on issue #995: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/995#issuecomment-572321045 Fixed checkstyle and findbugs complaint. This is an automated message from the Apache Git Se

[GitHub] [hbase] saintstack commented on issue #995: HBASE-23055 Alter hbase:meta

2020-01-08 Thread GitBox
saintstack commented on issue #995: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/995#issuecomment-572246784 @bharathv Thanks for review help. This is an automated message from the Apache Git Service.

[GitHub] [hbase] saintstack commented on issue #995: HBASE-23055 Alter hbase:meta

2020-01-08 Thread GitBox
saintstack commented on issue #995: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/995#issuecomment-572238258 Address most recent set of @bharathv comments (thanks for review!) This is an automated mes

[GitHub] [hbase] saintstack commented on issue #995: HBASE-23055 Alter hbase:meta

2020-01-08 Thread GitBox
saintstack commented on issue #995: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/995#issuecomment-572225043 Fix tests and checkstyle. Address @bharathv 's last set of comments. This is an automated me

[GitHub] [hbase] saintstack commented on issue #995: HBASE-23055 Alter hbase:meta

2020-01-07 Thread GitBox
saintstack commented on issue #995: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/995#issuecomment-571901659 Thanks for the review @bharathv . Helps. I just pushed some more checkstyle and test fixes. Will address your helpful comments in the morning. Thanks. -

[GitHub] [hbase] saintstack commented on issue #995: HBASE-23055 Alter hbase:meta

2020-01-07 Thread GitBox
saintstack commented on issue #995: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/995#issuecomment-571844515 Address helpful feedback. Fix test failures. This is an automated message from the Apache Gi