[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-26 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-650433945 bq. OK, got it. So you are talking about the whole design and Im expecting you are commenting on the patch. Yeah. This patch presumes a design that is only starting to

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-12 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-643352831 `Let's focus on the problems of this issue please? Stop shooting on air without any actual code...` I'm only here because I'm interested in discussion/design of meta

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-11 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-643055266 `The point here is when do you want to do this? In normal single read/write path, we just need to locate a single region. And for scanning, we need to locate to the next

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-11 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-643052700 `To be honest, I do not fully get your point on why we need to stick on the RegionLocator interface. ` This is not my point. My point is re-use known API or Interfaces

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-10 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-642393168 `On locating, if you want to locate to the next region, just use the end row of the current region to locate?` Caller has to take returned location, extract end

[GitHub] [hbase] saintstack commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-09 Thread GitBox
saintstack commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-641736719 Hopefully we can do work up front that makes it so new clients do not have to take a big pause while downloading MBs joining a big cluster. `There is no paging support