[GitHub] [hbase] saintstack commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-09-09 Thread GitBox
saintstack commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-689841833 @timoha closed it because no attention? This is an automated message from the Apache Git Service. To respond

[GitHub] [hbase] saintstack commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-25 Thread GitBox
saintstack commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-649243696 Updating TaskMonitor inside the method that deserializes procedure state data is a total surprise. I thought TaskMonitor best effort rather than a true view especially

[GitHub] [hbase] saintstack commented on pull request #1826: HBASE-24438 Don't update TaskMonitor when deserializing ServerCrashProcedure

2020-06-03 Thread GitBox
saintstack commented on pull request #1826: URL: https://github.com/apache/hbase/pull/1826#issuecomment-638346107 bq. should a simple fact of deserialization have such a side effect on tasks... No. That is wonky. For this reason alone we should apply this patch. Will