[GitHub] [hbase] saintstack commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-21 Thread GitBox
saintstack commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-678379917 Thank you for your notes on perf. Makes sense. Would suggest you put them on the JIRA itself @1996fanrui . Thi

[GitHub] [hbase] saintstack commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
saintstack commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677921557 The patch looks fine. My question is same as @virajjasani `...should have some benefits.` Can you quantify at all? --