saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-698113652
I deleted the backing HBASE-20505 branch in my repo to replace it w/ updated
version that addresses comments in here and made it against the HBASE-11870
branch at #2451 . This
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-698113652
I deleted the backing HBASE-20505 branch in my repo to replace it w/ updated
version that addresses comments in here and made it against the HBASE-11870
branch at #2451 . This
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-696233115
Let me try what you suggest. Will be back.
This is an automated message from the Apache Git Service.
To respond
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-696233115
Let me try what you suggest. Will be back.
This is an automated message from the Apache Git Service.
To respond
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-695054607
#2421 https://github.com/apache/hbase/pull/2421 extracts the minor changes
from this patch so this patch can be smaller on next iteration.
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-694982779
Looks like I misunderstood you then. I apologize. (Having trouble on when
and when not to R***).
`So to simplify the implementation, I suggest that first we could just
c
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-694645350
`Please take a look at my words again. I did not sale my job in HBASE-24950,
if I want to sale, why I would say that it does not suit here? Just want to
tell you drop the whole
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-694640598
`And there is also a whole in our implementation is that, when a RS first
carries meta region, it will create a WAL for meta region, but once we move
meta region out, the WAL w
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-694639883
`Sir, I would say you completely misunderstood me. What I mean here is you'd
better not consider ROOT, please consider both meta and normal region. But you
just dismissed my ap
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-694634837
```
Yes, let's do the refactoring. We have a queueStorage in ReplicationSource,
so in ReplicationSourceManager, if we have a ReplicationSource when we want to
store or load
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-694472828
Last push addressed Duo coments on code. TODO are the big items. I looked at
not passing WALFactory to ReplicationSourceFactory but then I'd have to pass a
specific WALProvider
saintstack commented on pull request #2413:
URL: https://github.com/apache/hbase/pull/2413#issuecomment-694407805
Thanks for the review.
`But in general, I think why we introduce a WALFileLengthProvider is that we
do not want to reference WALFactory and WALProvider directly in the re
12 matches
Mail list logo
