tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-866588630
@virajjasani @Apache9 @saintstack @anoopsjohn Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-866523876
> +1
Thanks @virajjasani for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-866451946
Hi @jojochuang , could you please take a look at this? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-864953216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-864965924
> Agree the test failures look unrelated. Rerunning tests just to be sure.
We can look at this. @anoopsjohn
--
This is an automated message from the Apache Git Service.
T
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-864964892
> I see +1 already from @Apache9. Are we waiting for some one else's
comments to be addressed?
> Agree the test failures look unrelated. Rerunning tests just to be sure.
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-864953216
Hi @virajjasani , could you please help to review the code? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-864696694
Hi @nyl3532016 , could you please do another review? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-864696305
org.apache.hadoop.hbase.TestJMXListener.(?)
org.apache.hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas.xml.[failed-to-read]
These failed unit tests are unrelate
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-864393471
Rebased to latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-861566124
Hi @wchevreuil , could you please take a look at this PR if you have time?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-861565963
Hi @wchevreuil , could you please take a look at this PR if you have time?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-861311298
Hi @jojochuang , could you please do another review? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-858211968
Hi @saintstack @Apache9 , could you please help me merge the code if there
are no other problems. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To r
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-857304782
Hi @Apache9 , I fixed the problem you mentioned. Could you please take a
look? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message,
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-856481326
Hi @saintstack , could you please take a look and merge the code? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-853535877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-854300252
> Those failed unit tests work fine locally.
>
>
org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.(?)
Hi @saintstack , could you please he
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-853535877
Those failed unit tests work fine locally.
org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController.(?)
--
This is an automated message from t
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-851417232
Hi @saintstack , those failed unit tests look unrelated to the change, and
they work fine locally.
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor5.testApp
tomscut commented on pull request #3325:
URL: https://github.com/apache/hbase/pull/3325#issuecomment-850205925
Failed tests:
org.apache.hadoop.hbase.regionserver.TestWALLockup.(?) (Those failed unit
tests are unrelated to the change, and they work fine locally)
org.apache.hadoop.
21 matches
Mail list logo
