[GitHub] [hbase] virajjasani commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-26 Thread GitBox
virajjasani commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-650329509 > Looks like there were consistent unit test failures in TestNormalizerOnCluster. let's keep an eye on it. Yeah, they pass locally all the time, on the build, it was

[GitHub] [hbase] virajjasani commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-25 Thread GitBox
virajjasani commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-649265950 > No, I think it's better to not try to get into that, especially if we think we'll bump the normalizer run interval to something much larger, like every 24 hours.

[GitHub] [hbase] virajjasani commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-24 Thread GitBox
virajjasani commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-648613548 > I think 5 mins is too short. I was thinking about it for huge clusters and yes it is quite possible for all plan completion to take longer time but I don't have any

[GitHub] [hbase] virajjasani commented on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-23 Thread GitBox
virajjasani commented on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-648208838 @ndimiduk @huaxiangsun I agree with logging "N plans submitted". That looks perfectly fine. Added commit for the same. So, now remains the only concern: `how we