[GitHub] [hbase] virajjasani commented on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-27 Thread GitBox
virajjasani commented on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-699800098 Thanks @infraio . Wondering if we should change `RsRpcServices` and `MasterRpcServices` to IA.LimitedPrivate instead of IA.Private. --

[GitHub] [hbase] virajjasani commented on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-27 Thread GitBox
virajjasani commented on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-699667581 I think old client capable of using old RPC should be a valid case of minor releases, let me just target for master branch for this change. Thought @infraio ? --

[GitHub] [hbase] virajjasani commented on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-25 Thread GitBox
virajjasani commented on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-698802996 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [hbase] virajjasani commented on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-25 Thread GitBox
virajjasani commented on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-698913517 Old client for this use-case would be 2.3.x releases and yes they would not be able to access new RPC. So the question is this might be an issue for any deprecated RPC A

[GitHub] [hbase] virajjasani commented on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-25 Thread GitBox
virajjasani commented on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-698802996 @infraio this sounds good to you? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] virajjasani commented on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-21 Thread GitBox
virajjasani commented on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-695942482 > Remove public API? When this API was added? Not exactly public API, it's RPC APIs. New RPC API was added as part of HBASE-24528 and is applicable to 2.4+ only. -

[GitHub] [hbase] virajjasani commented on pull request #2426: HBASE-25070 : With new generic API getLogEntries, cleaning up unused RPC APIs

2020-09-21 Thread GitBox
virajjasani commented on pull request #2426: URL: https://github.com/apache/hbase/pull/2426#issuecomment-695942482 > Remove public API? When this API was added? Not exactly public API, it's RPC APIs. New RPC API was added as part of HBASE-24528 and is applicable to 2.4+ only. -