[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-22 Thread GitBox
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-975344954 Also, now I see that @shahrs87 has also updated the description of the Jira HBASE-26468 and explained what exactly goes wrong and why server stays frozen if one of the non-dae

[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-22 Thread GitBox
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-975342397 > The problem here is that, why a crashed region server could return zero here? Why it does not return a non zero value? @Apache9 Regionserver doesn't crash, it exits no

[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-21 Thread GitBox
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974660177 Backport PRs: #3865 #3866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-20 Thread GitBox
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974660177 Backport PRs: #3865 #3866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974327935 Yeah that sounds right, server would have already been unresponsive. Also, nothing happens after call to `ServerCommandLine#doMain` in master and regionserver main methods so

[GitHub] [hbase] virajjasani commented on pull request #3862: HBASE-26468 Region Server doesn't exit cleanly incase it crashes.

2021-11-19 Thread GitBox
virajjasani commented on pull request #3862: URL: https://github.com/apache/hbase/pull/3862#issuecomment-974312848 This looks good actually, just wondering what could be the most destructive action that non-daemons could do. Maybe nothing? because regionserver/master is already (or in the