wchevreuil commented on pull request #2191:
URL: https://github.com/apache/hbase/pull/2191#issuecomment-673375360
retest build
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wchevreuil commented on pull request #2191:
URL: https://github.com/apache/hbase/pull/2191#issuecomment-674171455
> Can we do this at the end of the run method of ReplicationSourceShipper?
When removing the source, ReplicationSource.terminate will interrupt the
shipper thread and the
wchevreuil commented on pull request #2191:
URL: https://github.com/apache/hbase/pull/2191#issuecomment-680765886
retest build
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wchevreuil commented on pull request #2191:
URL: https://github.com/apache/hbase/pull/2191#issuecomment-688292670
Thanks for the review, @busbey , had pushed a new commit addressing those.
This is an automated message from t
wchevreuil commented on pull request #2191:
URL: https://github.com/apache/hbase/pull/2191#issuecomment-692612301
> I left a few suggestions, but I think this is also looks fine as-is.
Thanks for reviewing it @joshelser . Added the TRACE logging, replied on the
other suggestions. Min
