wchevreuil commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-933592090
> In general I do not like that we introduce a new init method but do not
call it when verifying...
It's a mean to separate instantiation of SFT impls, from actual init l
wchevreuil commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-934457567
> A possible way is to pass in a null StoreContext, and the implementation
class should check whether the StoreContext is null, if so, then it should
construct itself in the 'p
wchevreuil commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-937158799
I'm sorry @Apache9 , but why did you force push all these commits into the
branch? I believe it had no conflicts with HBASE-26067 before.
--
This is an automated message from
wchevreuil commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-937584379
> I just rebased
[HBASE-26067](https://issues.apache.org/jira/browse/HBASE-26067) against the
newest master branch, and seems GitHub can not identify this type of rebase so
it
wchevreuil commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-937591510
I'm not sure why github is showing all these additional commits, it should
have the option to rebase.
--
This is an automated message from the Apache Git Service.
To respond
wchevreuil commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-937818470
> The TestStoreFileTracker.testHasPersistConfiguration method is used to
make sure that all the implementation classes have the correct static method.
My problem with thi
wchevreuil commented on pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#issuecomment-937158799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
