z-york commented on a change in pull request #2650:
URL: https://github.com/apache/hbase/pull/2650#discussion_r522528641
##########
File path: hbase-shell/src/main/ruby/shell/commands/count.rb
##########
@@ -60,17 +71,27 @@ def count(table, params = {})
# If the second parameter is an integer, then it is the old command
syntax
params = { 'INTERVAL' => params } if params.is_a?(Integer)
+ # Try to be nice and convert a string to a bool
+ if params.include?('CACHE_BLOCKS') and
params['CACHE_BLOCKS'].is_a?(String)
+ if params['CACHE_BLOCKS'].downcase == 'true'
+ params['CACHE_BLOCKS'] = true
+ elsif params['CACHE_BLOCKS'].downcase == 'false'
+ params['CACHE_BLOCKS'] = false
+ end
Review comment:
Maybe worth throwing an error back if it isn't true or false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
