[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-12 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1323047115 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java: ## @@ -196,13 +196,17 @@ static boolean isEmptyStopRow(byte[] row) { return

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-11 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1321804040 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -692,6 +711,13 @@ public void updateRpc(MethodDescriptor method, Message

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-09-09 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1320499288 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -753,6 +787,40 @@ public void updateRpc(MethodDescriptor method, Message

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-08-20 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1299339417 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java: ## @@ -346,10 +346,9 @@ public static RegionAction.Builder

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-08-19 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1299211671 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java: ## @@ -346,10 +346,9 @@ public static RegionAction.Builder

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-08-18 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1299028446 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java: ## @@ -346,10 +346,9 @@ public static RegionAction.Builder

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-08-13 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1292911895 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -732,6 +770,32 @@ public void updateRpc(MethodDescriptor method, Message

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-08-13 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1292678337 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java: ## @@ -732,6 +770,32 @@ public void updateRpc(MethodDescriptor method, Message

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-08-13 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1292674173 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java: ## @@ -346,10 +346,9 @@ public static RegionAction.Builder

[GitHub] [hbase] zhuyaogai commented on a diff in pull request #5228: HBASE-27853 Add client side table metrics for rpc calls and request latency.

2023-08-13 Thread via GitHub
zhuyaogai commented on code in PR #5228: URL: https://github.com/apache/hbase/pull/5228#discussion_r1292674173 ## hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/RequestConverter.java: ## @@ -346,10 +346,9 @@ public static RegionAction.Builder