joshelser commented on issue #8: HBASE-23076 [HBOSS] ZKTreeLockManager shouldn't try to acquire a lock from the InterProcessMutex instance when checking if other processes hold it. URL: https://github.com/apache/hbase-filesystem/pull/8#issuecomment-535093164 For reference, I wrote a little test that spun up 100 clients all trying to read the same file, ~5directories beneath the root of the filesystem (analogous to reading a table descriptor when opening a region). At `HEAD`, this took about 80 seconds. With Wellington's change here, it takes about 400ms. The other concern I had was around the correctness of the change, but TreeLockManager is always checking for a conflicting lock after it grabs the new lock in ZK. Best as I can think through things, that means we're just fine. Really good change, Wellington!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
