NihalJain commented on PR #135:
URL:
https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1690226389
In order to test the change build codebase locally and deployed hbck2 jar on
a real cluster running 2.5x.
For overall tool tested following:
- Run help and ensure
NihalJain commented on PR #135:
URL:
https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1690281118
Based on code, I was able to identify 3 commands: `assigns`, `unassigns` and
`bypass`, which should have batching in case large list of input is passed and
have made a chang
NihalJain commented on PR #135:
URL:
https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1706728002
Rebased code and removed unrelated code format changes as they have already
been fixed with https://github.com/apache/hbase-operator-tools/pull/137
@petersomogyi , @wc
NihalJain commented on PR #135:
URL:
https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1708419642
> Nice improvement! I only have a minor comment on the log.
Fixed the review comment. Thanks for taking time to review this
@petersomogyi.
I will wait until EOD fo
NihalJain commented on PR #135:
URL:
https://github.com/apache/hbase-operator-tools/pull/135#issuecomment-1708819815
> Also, I observed that the semantics of what is printed in sysout is not
well defined. For few commands, say `assigns`, it prints output as a list:
`[425, 426, 427, 428, 42
