Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-12-21 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1866077717 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-12-21 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1866065379 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-12-21 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1866044838 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-12-21 Thread via GitHub
zhuyaogai commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1865986211 @Apache9 @bbeaudreault hi, I have made some code modifications, could you review code and provide some suggestions if you are available? Thanks! -- This is an automated message from

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-11-08 Thread via GitHub
Apache9 commented on code in PR #5428: URL: https://github.com/apache/hbase/pull/5428#discussion_r1386716309 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java: ## @@ -467,6 +467,7 @@ public enum NextState { MORE_VALUES(true, false),

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-11-06 Thread via GitHub
zhuyaogai commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1794473875 Gentle ping @Apache9 If u have time, could u help review this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751985986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751984670 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751980124 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751970011 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751969585 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751969508 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751963201 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751962747 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
Apache-HBase commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751962587 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28107 Limit max count of rows filtered per scan request. [hbase]

2023-10-08 Thread via GitHub
zhuyaogai commented on PR #5428: URL: https://github.com/apache/hbase/pull/5428#issuecomment-1751957889 @Apache9 @bbeaudreault hi, I have changed code a bit, with the limitation of the maximum filtered rows for each scan request, and allowing users to optionally kill the scan request.