virajjasani merged PR #5493:
URL: https://github.com/apache/hbase/pull/5493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apa
virajjasani commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1901238713
Though now i am convinced that we usually do need to bypass transit state
checks almost majority of the times when we have to use hbck in prod :)
--
This is an automated message from
rahulLiving commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1900489145
@virajjasani @apurtell Can you please help with the merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
rahulLiving commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1865536827
@rvaleti @virajjasani I have updated the PR to keep backward compatibility
i.e default is `force=True` now. Please have a look
--
This is an automated message from the Apache Git Ser
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864859976
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864858088
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864532113
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864448444
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864402842
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1864115146
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1862624589
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1862624493
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1862624305
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s | Docker
rvaleti commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1857382130
@rahulLiving This API change would break old operator-tools's hbck2. Please
make sure it is backward compatible.
--
This is an automated message from the Apache Git Service.
To respond t
virajjasani commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1857380091
Oh right, that won't work.
But i think that makes this bit more complicated from compatibility
viewpoint. For instance, we can't roll this change out while hbck2 does not
have an opt
rahulLiving commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1857371936
>first make the changes in hbase-operator-tools by adding new option
Adding an option in `operator-tool` without exposing API at `hbase` side
won't help, right?
Wanted to get
virajjasani commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1856404780
I wonder if we should make changes the other way around i.e. first make the
changes in hbase-operator-tools by adding new option, documenting it and only
when operator-tools bumps hbase
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1810729976
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1810708470
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1810240143
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1810154488
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1810095720
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1809774892
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s | Docker
rahulLiving commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1809714745
@virajjasani @apurtell Please review.
I am wondering how, do we release operator tool side of change along with
this ? Is it handled separately, since latest on hbase master change
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1809659968
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1809652914
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1809651614
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s | Docker
rahulLiving commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1809611020
```
[ERROR] Errors:
[ERROR] org.apache.hadoop.hbase.master.TestMergeTableRegionsWhileRSCrash.null
[ERROR] Run 1: TestMergeTableRegionsWhileRSCrash.test:109 » TestTimedOut
te
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1808412357
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 17s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1808216992
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1807896917
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792835496
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792808458
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792431535
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792339747
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792334120
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1792030062
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1791357304
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1791355252
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1790971680
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s | Docke
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1790868187
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1790701640
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1790423166
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1790308487
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1790304987
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Docker
Apache-HBase commented on PR #5493:
URL: https://github.com/apache/hbase/pull/5493#issuecomment-1790299163
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s | Docker
rahulLiving opened a new pull request, #5493:
URL: https://github.com/apache/hbase/pull/5493
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
47 matches
Mail list logo
