bbeaudreault merged PR #5481:
URL: https://github.com/apache/hbase/pull/5481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1795946764
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1795940118
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1795095329
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 22s |
rmdmattingly commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1383448371
##
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/RpcLogDetails.java:
##
@@ -60,6 +64,18 @@ public RpcLogDetails(RpcCall rpcCall, Message param,
virajjasani commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1382729277
##
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/RpcLogDetails.java:
##
@@ -60,6 +64,18 @@ public RpcLogDetails(RpcCall rpcCall, Message param,
rmdmattingly commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1792336698
The test failures above are unrelated. I believe this is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1791731953
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1791477391
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 13s |
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1791433662
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1791364785
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1790972366
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
rmdmattingly commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1380257911
##
hbase-server/src/test/java/org/apache/hadoop/hbase/namequeues/TestRpcLogDetails.java:
##
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation
rmdmattingly commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1380257911
##
hbase-server/src/test/java/org/apache/hadoop/hbase/namequeues/TestRpcLogDetails.java:
##
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1782122811
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1782102297
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781881495
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
bbeaudreault commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781872024
An alternative approach here might be to find a way to call
ByteBuffer.retain() when creating the SlowLogParams, and then
ByteBuffer.release() when consuming in SlowLogService. That
rmdmattingly commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1373772349
##
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/RpcLogDetails.java:
##
@@ -60,6 +66,40 @@ public RpcLogDetails(RpcCall rpcCall, Message param,
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781836520
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
rmdmattingly commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781832520
Nice, I like that idea! I'm headed out on vacation tonight, but will add
that test when I return later next week
--
This is an automated message from the Apache Git Service.
To
bbeaudreault commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781829679
This might seem silly, but I wonder if you could at least do the simple test
of:
- Create a protobuf and write it to a ByteBuffer
- Create another protobuf backed by a
bbeaudreault commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1373529325
##
hbase-server/src/main/java/org/apache/hadoop/hbase/namequeues/RpcLogDetails.java:
##
@@ -60,6 +66,40 @@ public RpcLogDetails(RpcCall rpcCall, Message param,
rmdmattingly commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781551210
It would be difficult to reliably reproduce the overwriting of the input
buffer in a unit test, but maybe it's possible. We could probably write a unit
test which confirms the copied
rmdmattingly commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1373417312
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogParams.java:
##
@@ -82,7 +82,7 @@ public boolean equals(Object o) {
}
SlowLogParams
Apache-HBase commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781481339
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
rmdmattingly commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1373417312
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogParams.java:
##
@@ -82,7 +82,7 @@ public boolean equals(Object o) {
}
SlowLogParams
rmdmattingly opened a new pull request, #5481:
URL: https://github.com/apache/hbase/pull/5481
The RpcLogDetails class represents a slow (or large) log event which will
later be consumed by the SlowLogQueueService.
Right now the RpcLogDetails' param field points to the slow call's
28 matches
Mail list logo
