shahrs87 merged PR #5505:
URL: https://github.com/apache/hbase/pull/5505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shahrs87 merged PR #5504:
URL: https://github.com/apache/hbase/pull/5504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shahrs87 commented on PR #5504:
URL: https://github.com/apache/hbase/pull/5504#issuecomment-1799422621
```
[INFO] ---
[INFO] T E S T S
[INFO] ---
[INFO] Running
shahrs87 merged PR #5503:
URL: https://github.com/apache/hbase/pull/5503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1797092976
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5504:
URL: https://github.com/apache/hbase/pull/5504#issuecomment-1797091530
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5504:
URL: https://github.com/apache/hbase/pull/5504#issuecomment-1797080416
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s |
Apache-HBase commented on PR #5505:
URL: https://github.com/apache/hbase/pull/5505#issuecomment-1797074760
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1797071191
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
Apache-HBase commented on PR #5505:
URL: https://github.com/apache/hbase/pull/5505#issuecomment-1797036623
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5505:
URL: https://github.com/apache/hbase/pull/5505#issuecomment-1796409945
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
Apache-HBase commented on PR #5504:
URL: https://github.com/apache/hbase/pull/5504#issuecomment-1796401330
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 28s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1796304020
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5504:
URL: https://github.com/apache/hbase/pull/5504#issuecomment-1794140066
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5504:
URL: https://github.com/apache/hbase/pull/5504#issuecomment-1794126435
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 25s |
Apache-HBase commented on PR #5505:
URL: https://github.com/apache/hbase/pull/5505#issuecomment-1794119741
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5505:
URL: https://github.com/apache/hbase/pull/5505#issuecomment-1794118954
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
virajjasani commented on code in PR #5503:
URL: https://github.com/apache/hbase/pull/5503#discussion_r1382734340
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java:
##
@@ -470,7 +470,27 @@ private Pair
Apache9 commented on code in PR #5505:
URL: https://github.com/apache/hbase/pull/5505#discussion_r1382731051
##
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryStream.java:
##
@@ -258,7 +258,26 @@ private void dequeueCurrentLog() throws
Apache-HBase commented on PR #5504:
URL: https://github.com/apache/hbase/pull/5504#issuecomment-1793983646
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 29s |
Apache-HBase commented on PR #5505:
URL: https://github.com/apache/hbase/pull/5505#issuecomment-1793979472
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
shahrs87 opened a new pull request, #5505:
URL: https://github.com/apache/hbase/pull/5505
master branch PR: https://github.com/apache/hbase/pull/5503
branch-2 PR: https://github.com/apache/hbase/pull/5504
branc
--
This is an automated message from the Apache Git Service.
To respond
shahrs87 commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793946159
PR for branch-2: https://github.com/apache/hbase/pull/5504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
shahrs87 opened a new pull request, #5504:
URL: https://github.com/apache/hbase/pull/5504
PR for master branch: https://github.com/apache/hbase/pull/5503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Apache9 commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793925161
The code is bit different on branch-2.5 and branch-2.4, please open a
separated PR for against branch-2.5?
Thanks.
--
This is an automated message from the Apache Git Service.
To
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793910593
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 13s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793908482
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 11s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793847279
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 1s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793549851
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793549379
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793497710
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
shahrs87 commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793489303
Thank you @Apache9 for your feedback and your requested comments are very
detailed. Made the changes. Can you please review again? Thank you !
--
This is an automated message from the
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793277127
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 22s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793275696
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5503:
URL: https://github.com/apache/hbase/pull/5503#issuecomment-1793120454
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
shahrs87 opened a new pull request, #5503:
URL: https://github.com/apache/hbase/pull/5503
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
36 matches
Mail list logo