taklwu merged PR #5527:
URL: https://github.com/apache/hbase/pull/5527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5527:
URL: https://github.com/apache/hbase/pull/5527#issuecomment-1819659612
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 19s |
Apache-HBase commented on PR #5527:
URL: https://github.com/apache/hbase/pull/5527#issuecomment-1819608388
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 22s |
Apache-HBase commented on PR #5527:
URL: https://github.com/apache/hbase/pull/5527#issuecomment-1819198644
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
Apache-HBase commented on PR #5527:
URL: https://github.com/apache/hbase/pull/5527#issuecomment-1816278083
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Apache-HBase commented on PR #5527:
URL: https://github.com/apache/hbase/pull/5527#issuecomment-1816252258
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5527:
URL: https://github.com/apache/hbase/pull/5527#issuecomment-1816241847
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 14s |
wchevreuil opened a new pull request, #5527:
URL: https://github.com/apache/hbase/pull/5527
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
wchevreuil closed pull request #5526: HBASE-28186 Rebase CacheAwareBalance
related commits into master branch
URL: https://github.com/apache/hbase/pull/5526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
wchevreuil opened a new pull request, #5526:
URL: https://github.com/apache/hbase/pull/5526
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
wchevreuil merged PR #5519:
URL: https://github.com/apache/hbase/pull/5519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1813164663
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1813156156
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1812843273
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1812515383
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1812519791
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1812515094
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
wchevreuil commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1811176350
It looks like the pre-commit build fails to acknowledge the protobuf
changes, ain't sure why.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1810458034
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1810449661
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1810449393
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1810407832
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
wchevreuil commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1810324868
Thanks @taklwu @meszibalu for the suggestions. I'm trying to get the PR
passing build first by push each commit individually, please hold on from
reviewing it for now until I have all
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1810290790
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
meszibalu commented on code in PR #5519:
URL: https://github.com/apache/hbase/pull/5519#discussion_r1392573142
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchProtoUtils.java:
##
@@ -26,8 +28,26 @@ private PrefetchProtoUtils() {
}
static
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1809965337
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
taklwu commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1809017870
mostly good but can you fix all build failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1808405167
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1808394214
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5519:
URL: https://github.com/apache/hbase/pull/5519#issuecomment-1808391959
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 46s |
wchevreuil closed pull request #5500: HBASE-28186 Rebase CacheAwareBalance
related commits into master branch
URL: https://github.com/apache/hbase/pull/5500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1805722076
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1805705652
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1805702953
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
wchevreuil commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1805664607
@taklwu , I had now squashed the rebase commits with the original ones and
solved the conflicts. I believe this would allow us to merge only the original
4 commits from @ragarkar into
wchevreuil commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1805399308
>also I'm wondered how these patches will be landing in master, will it be a
single commit ? or will we keep the history of those verified commits , and
those rebasing commit how would
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1792698415
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1792567878
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1792234552
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
ragarkar commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1792050379
> @ragarkar can share more details about his tests results.
Added test results information showing that the regions are retained by the
region server beyond server restart and the
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1791914752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1791762106
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5500:
URL: https://github.com/apache/hbase/pull/5500#issuecomment-1791761228
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
wchevreuil opened a new pull request, #5500:
URL: https://github.com/apache/hbase/pull/5500
This PR is for rebasing all the CacheAwareBalancer commits into master.
Rahul has shared the [design
44 matches
Mail list logo
