Apache9 merged PR #5583:
URL: https://github.com/apache/hbase/pull/5583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhuyaogai commented on PR #5583:
URL: https://github.com/apache/hbase/pull/5583#issuecomment-1857377414
@Apache9 hi, could you help review the code when you have time? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Apache-HBase commented on PR #5583:
URL: https://github.com/apache/hbase/pull/5583#issuecomment-1856151064
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache-HBase commented on PR #5583:
URL: https://github.com/apache/hbase/pull/5583#issuecomment-1856119776
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache9 commented on PR #5583:
URL: https://github.com/apache/hbase/pull/5583#issuecomment-1855954858
> @Apache9 hi, could you tell me why `testDeadlockWithSyncOverwrites` test
case was removed from `TestFSHLog` in the `master` branch?
Apache-HBase commented on PR #5583:
URL: https://github.com/apache/hbase/pull/5583#issuecomment-1855782454
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 16s |
zhuyaogai commented on PR #5583:
URL: https://github.com/apache/hbase/pull/5583#issuecomment-1855737457
@Apache9 hi, could you tell me why `testDeadlockWithSyncOverwrites` test
case was removed from `TestFSHLog` in the `master` branch?
zhuyaogai opened a new pull request, #5583:
URL: https://github.com/apache/hbase/pull/5583
Detail: HBASE-28190 and backport for branch-2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Apache9 merged PR #5507:
URL: https://github.com/apache/hbase/pull/5507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1850083564
TestZooKeeper is known to be flaky sometimes in pre commit.
TestRollbackSCP is tracked by #5563
Let me merge.
--
This is an automated message from the Apache Git Service.
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1850076030
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1850062454
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1849682483
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 26s |
zhuyaogai commented on code in PR #5507:
URL: https://github.com/apache/hbase/pull/5507#discussion_r1422130655
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestLogRolling.java:
##
@@ -74,6 +82,12 @@ public abstract class AbstractTestLogRolling
Apache9 commented on code in PR #5507:
URL: https://github.com/apache/hbase/pull/5507#discussion_r1422083189
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/AbstractTestLogRolling.java:
##
@@ -74,6 +82,12 @@ public abstract class AbstractTestLogRolling {
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1837585346
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1837583635
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1837531976
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 33s |
zhuyaogai commented on code in PR #5507:
URL: https://github.com/apache/hbase/pull/5507#discussion_r1413139728
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.java:
##
@@ -51,6 +60,64 @@ public static void setUpBeforeClass() throws
zhuyaogai commented on code in PR #5507:
URL: https://github.com/apache/hbase/pull/5507#discussion_r1413139728
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.java:
##
@@ -51,6 +60,64 @@ public static void setUpBeforeClass() throws
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1837466945
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 32s |
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1837464638
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 35s |
Apache9 commented on code in PR #5507:
URL: https://github.com/apache/hbase/pull/5507#discussion_r1413023292
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.java:
##
@@ -51,6 +60,64 @@ public static void setUpBeforeClass() throws
Apache-HBase commented on PR #5507:
URL: https://github.com/apache/hbase/pull/5507#issuecomment-1837393085
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 49s |
zhuyaogai commented on code in PR #5507:
URL: https://github.com/apache/hbase/pull/5507#discussion_r1413012164
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.java:
##
@@ -51,6 +60,56 @@ public static void setUpBeforeClass() throws
Apache9 commented on code in PR #5507:
URL: https://github.com/apache/hbase/pull/5507#discussion_r1412810438
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestAsyncLogRolling.java:
##
@@ -51,6 +60,56 @@ public static void setUpBeforeClass() throws
26 matches
Mail list logo
