Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

wchevreuil merged PR #5530: URL: https://github.com/apache/hbase/pull/5530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apac

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

wchevreuil commented on code in PR #5530: URL: https://github.com/apache/hbase/pull/5530#discussion_r1408399669 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -642,12 +643,14 @@ void blockEvicted(BlockCacheKey cacheKey, BucketEntry

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache9 commented on code in PR #5530: URL: https://github.com/apache/hbase/pull/5530#discussion_r1407672046 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -642,12 +643,14 @@ void blockEvicted(BlockCacheKey cacheKey, BucketEntry bu

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1823568590 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1823495173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 14s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1823140738 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822930537 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822931412 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822930810 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache9 commented on code in PR #5530: URL: https://github.com/apache/hbase/pull/5530#discussion_r1402182196 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -642,12 +643,14 @@ void blockEvicted(BlockCacheKey cacheKey, BucketEntry bu

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache9 commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822914756 OK, two methods... I expanded the code and got the point... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822563906 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822565402 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822562225 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822559235 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822559218 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1822558986 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821712463 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821687097 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821382224 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

wchevreuil commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821288528 > To be honest I can not fully understand why the description on jira will lead to code change in this PR... Especially you mentioned we may still fail to cache the entry so the entry in

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821154169 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1821147797 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache9 commented on code in PR #5530: URL: https://github.com/apache/hbase/pull/5530#discussion_r1400744146 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -221,13 +221,14 @@ public class BucketCache implements BlockCache, HeapSize

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1820786996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1819822970 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docker

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1819758726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s | Docke

Re: [PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

Apache-HBase commented on PR #5530: URL: https://github.com/apache/hbase/pull/5530#issuecomment-1819460763 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 2s | Docke

[PR] HBASE-28211 BucketCache.blocksByHFile may leak on allocationFailure or if we reach io errors tolerated [hbase]

wchevreuil opened a new pull request, #5530: URL: https://github.com/apache/hbase/pull/5530 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m