Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-12 Thread via GitHub
frostruan commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1852147999 +1 nice UT! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1850565146 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1850533799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-11 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1850138051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-06 Thread via GitHub
hiping-tech commented on code in PR #5560: URL: https://github.com/apache/hbase/pull/5560#discussion_r1417277176 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java: ## @@ -442,7 +442,7 @@ protected ProcedureMetrics

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-05 Thread via GitHub
Apache9 commented on code in PR #5560: URL: https://github.com/apache/hbase/pull/5560#discussion_r1416608198 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java: ## @@ -442,7 +442,7 @@ protected ProcedureMetrics

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-05 Thread via GitHub
frostruan commented on code in PR #5560: URL: https://github.com/apache/hbase/pull/5560#discussion_r1416595305 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java: ## @@ -442,7 +442,7 @@ protected ProcedureMetrics

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-05 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1841326321 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-05 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1841299286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28241 Fixed the check for an ongoing Snapshot before proceeding with the merge region operation. [hbase]

2023-12-05 Thread via GitHub
Apache-HBase commented on PR #5560: URL: https://github.com/apache/hbase/pull/5560#issuecomment-1840874206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |