2005hithlj opened a new pull request, #6130:
URL: https://github.com/apache/hbase/pull/6130
https://issues.apache.org/jira/browse/HBASE-28389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
2005hithlj opened a new pull request, #6131:
URL: https://github.com/apache/hbase/pull/6131
https://issues.apache.org/jira/browse/HBASE-28389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
2005hithlj commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257444254
@DieterDP-ng @Apache9 Could you take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257472872
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257474240
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257474705
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257476559
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
DieterDP-ng commented on code in PR #6130:
URL: https://github.com/apache/hbase/pull/6130#discussion_r1696581571
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java:
##
@@ -335,8 +335,8 @@ public void execute() throws IOException {
if (
2005hithlj commented on code in PR #6130:
URL: https://github.com/apache/hbase/pull/6130#discussion_r1696627600
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java:
##
@@ -335,8 +335,8 @@ public void execute() throws IOException {
if (c
Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257941409
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257943529
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257948240
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Apache-HBase commented on PR #6130:
URL: https://github.com/apache/hbase/pull/6130#issuecomment-2257961522
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
DieterDP-ng commented on code in PR #6130:
URL: https://github.com/apache/hbase/pull/6130#discussion_r1696926702
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java:
##
@@ -335,8 +335,8 @@ public void execute() throws IOException {
if (
2005hithlj merged PR #6130:
URL: https://github.com/apache/hbase/pull/6130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apac
Apache-HBase commented on PR #6131:
URL: https://github.com/apache/hbase/pull/6131#issuecomment-2259523222
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
Apache-HBase commented on PR #6131:
URL: https://github.com/apache/hbase/pull/6131#issuecomment-2259525963
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexe
2005hithlj commented on PR #6131:
URL: https://github.com/apache/hbase/pull/6131#issuecomment-2259631023
This PR for branch master and branch-3.
@DieterDP-ng @Apache9 Could you take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the mess
NihalJain commented on code in PR #6131:
URL: https://github.com/apache/hbase/pull/6131#discussion_r1697928408
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreDriver.java:
##
@@ -124,8 +124,8 @@ private int parseAndRun() throws IOException {
if (cmd.ha
NihalJain commented on code in PR #6131:
URL: https://github.com/apache/hbase/pull/6131#discussion_r1697929155
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java:
##
@@ -142,6 +142,12 @@ public void execute() throws IOException {
throw
NihalJain commented on PR #6131:
URL: https://github.com/apache/hbase/pull/6131#issuecomment-2259716917
Also could you please how this PR was tested? I am not sure if writing a UT
would be straightforward, if possible that would be great!
--
This is an automated message from the Apache Gi
2005hithlj commented on code in PR #6131:
URL: https://github.com/apache/hbase/pull/6131#discussion_r1698423825
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreDriver.java:
##
@@ -124,8 +124,8 @@ private int parseAndRun() throws IOException {
if (cmd.h
2005hithlj commented on code in PR #6131:
URL: https://github.com/apache/hbase/pull/6131#discussion_r1698430916
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java:
##
@@ -142,6 +142,12 @@ public void execute() throws IOException {
thro
NihalJain commented on code in PR #6131:
URL: https://github.com/apache/hbase/pull/6131#discussion_r1698469419
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupCommands.java:
##
@@ -142,6 +142,12 @@ public void execute() throws IOException {
throw
2005hithlj commented on PR #6131:
URL: https://github.com/apache/hbase/pull/6131#issuecomment-2260493359
@NihalJain Thanks for your review. @DieterDP-ng has verified "Setting the
queue through the configuration does work.", and the changes here is also
simple and clear. Besides, the UT for
2005hithlj merged PR #6131:
URL: https://github.com/apache/hbase/pull/6131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apac
26 matches
Mail list logo
