Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

wchevreuil merged PR #5905: URL: https://github.com/apache/hbase/pull/5905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2124773323 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2124659494 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2124160809 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2121957563 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2121951760 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2121931907 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1607734006 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,10 @@ public HFileBlock readBlock(long dataBlockOffset, long

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

wchevreuil commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1607171526 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,10 @@ public HFileBlock readBlock(long dataBlockOffset, long

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2117172498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 24m 53s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2117108925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2117068544 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1604514473 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java: ## @@ -275,6 +275,18 @@ public boolean shouldCacheBlockOnRead(BlockCategory category)

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1604512451 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -471,6 +474,62 @@ public void testFeatureKeyDisabled() throws

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1604512006 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java: ## @@ -275,6 +275,18 @@ public boolean shouldCacheBlockOnRead(BlockCategory category)

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

vinayakphegde commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1604469915 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -471,6 +474,62 @@ public void testFeatureKeyDisabled() throws

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

wchevreuil commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1603657884 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2115366847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2115325617 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2115318057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114890243 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114854114 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2114812889 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1602908275 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113070051 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113063306 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2113047961 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

wchevreuil commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1601975139 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java: ## @@ -1357,9 +1357,16 @@ public HFileBlock readBlock(long dataBlockOffset, long