Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-06-05 Thread via GitHub
stoty commented on code in PR #5830: URL: https://github.com/apache/hbase/pull/5830#discussion_r1628780005 ## hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java: ## @@ -770,7 +770,7 @@ protected void addDefaultApps(ContextHandlerCollection parent, final Strin

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-06-05 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2151137118 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s | Docke

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-06-05 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2151113769 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docke

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-06-05 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2151105596 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s | Docke

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-06-05 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2150766333 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-24 Thread via GitHub
stoty commented on code in PR #5830: URL: https://github.com/apache/hbase/pull/5830#discussion_r1578277091 ## hbase-shaded/hbase-shaded-testing-util/src/main/resources/org/apache/hadoop/hbase/shaded/org/eclipse/jetty/webapp/webdefault.xml: ## @@ -159,15 +159,15 @@ limitations un

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-24 Thread via GitHub
Kota-SH commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2075475481 > The changes look OK. > > My concern is whether this breaks existing functionality. IIRC there are some screens where the UI lets you download files. Won't those be broken by this c

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-23 Thread via GitHub
stoty commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2074190662 The changes look OK. My concern is whether this breaks existing functionality. IIRC there are some screens where the UI lets you download files. Won't those be broken by this chang

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-21 Thread via GitHub
Apache9 commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2068065244 Mind explaining a bit? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2057993264 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docke

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2057972723 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docke

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2057960877 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docke

Re: [PR] HBASE-28514: HBase web console automatically listing directories in static/css [hbase]

2024-04-15 Thread via GitHub
Apache-HBase commented on PR #5830: URL: https://github.com/apache/hbase/pull/5830#issuecomment-2057666230 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker