Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-06-06 Thread via GitHub
ndimiduk merged PR #5868: URL: https://github.com/apache/hbase/pull/5868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-06-05 Thread via GitHub
bbeaudreault commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2150791969 In fact I'm going to send an email to the dev list so that @DieterDP-ng and his team can also list any jiras we want to try to get into that release. -- This is an automated message

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-06-05 Thread via GitHub
bbeaudreault commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2150790036 Thanks for the ping @Apache9. It looks like this is ready, but I've asked @rmdmattingly and @ndimiduk to take one more like and handle committing if it's working for us internally.

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-06-05 Thread via GitHub
Apache9 commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2150396889 Ping @bbeaudreault . I think this should be merged so we can start releasing 2.6.1? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139150247 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139140835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 20s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139135687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139115176 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
DieterDP-ng commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2139066109 Requested changes applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-30 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1620230862 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java: ## @@ -281,13 +284,65 @@ protected void addManifest(BackupInfo backupInfo,

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-22 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1610231908 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-22 Thread via GitHub
ndimiduk commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1609532907 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/TableBackupClient.java: ## @@ -281,13 +284,65 @@ protected void addManifest(BackupInfo backupInfo, Bac

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-21 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1608768506 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-21 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1608525945 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-21 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1607915006 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-20 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1607192892 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113502179 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113496816 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113495636 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113491628 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-15 Thread via GitHub
DieterDP-ng commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2113452806 @rmdmattingly rebased the PR after addressing the `getAncestors` concerns. The test failure in previous version is a flaky test, it also occurs in https://github.com/apache/hbase/pull/5

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-08 Thread via GitHub
rmdmattingly commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2100346207 A rebase and force push should be good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-08 Thread via GitHub
DieterDP-ng commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2100112584 I'll update the PR once https://github.com/apache/hbase/pull/5871 gets merged. Not sure how to handle the rebasing of these changes? Should I do a force-push of this branch, or simply c

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-07 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1593126783 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +296,32 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-07 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1593124868 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-06 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1590961068 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-06 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1590736669 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-06 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1590736669 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-06 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1590726707 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +296,32 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-06 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1590689156 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589682053 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +296,32 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589682053 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +296,32 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093660305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093657474 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093651839 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s | Docker

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589656522 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +296,32 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093646413 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589641498 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589634611 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589623676 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589613264 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589581275 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo backupInfo)

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093286191 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093284466 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093282294 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093269408 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-03 Thread via GitHub
DieterDP-ng commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1589353145 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,47 +295,10 @@ public ArrayList getAncestors(BackupInfo backupInfo) t

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-02 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2091039497 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-02 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2091038972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-02 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2091034175 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docke

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-02 Thread via GitHub
Apache-HBase commented on PR #5868: URL: https://github.com/apache/hbase/pull/5868#issuecomment-2091004633 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker

Re: [PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-02 Thread via GitHub
rmdmattingly commented on code in PR #5868: URL: https://github.com/apache/hbase/pull/5868#discussion_r1587901054 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java: ## @@ -295,47 +295,10 @@ public ArrayList getAncestors(BackupInfo backupInfo)

[PR] HBASE-28562 Correct backup ancestor calculation [hbase]

2024-05-02 Thread via GitHub
DieterDP-ng opened a new pull request, #5868: URL: https://github.com/apache/hbase/pull/5868 The ancestor calculation was wrong for incremental backups: when requesting the ancestors for an incremental backup X, the ancestors could include both full and incremental backups that predate the