[
https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421934#comment-13421934
]
Andrew Purtell edited comment on HBASE-6407 at 7/25/12 1:40 AM:
----------------------------------------------------------------
bq. However I think that the benfits to testing alone will be worth it.
I'm inclined to agree.
bq. Yes it's a big patch.
It's fine if you just want to contribute a big patch, but for commit it might
make sense to put in the core of the work (POM update, HBaseGuice,
ExplicitConfModule). Then Sleeper. Then the modularization of LocalHBaseCluster
and therefore factories for HMaster, HRegionServer, etc. Then the
modularization of HadoopCompat. Then the replication modules. It looks not to
difficult to tease this apart that way (so far). What do other committers think?
Edit: Remove paste-o, I was sure I ^Xed it.
was (Author: apurtell):
bq. However I think that the benfits to testing alone will be worth it.
I'm inclined to agree.
bq. Yes it's a big patch.
It's fine if you just want to contribute a big patch, but for commit it might
make sense to put in the core of the work (POM update, HBaseGuice,
AbstractModule. ExplicitConfModule). Then Sleeper. Then the modularization of
LocalHBaseCluster and therefore factories for HMaster, HRegionServer, etc. Then
the modularization of HadoopCompat. Then the replication modules. It looks not
to difficult to tease this apart that way (so far). What do other committers
think?
> Investigate moving to DI (guice) framework for plugin arch.
> -----------------------------------------------------------
>
> Key: HBASE-6407
> URL: https://issues.apache.org/jira/browse/HBASE-6407
> Project: HBase
> Issue Type: Sub-task
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Attachments: HBASE-6407-1.patch
>
>
> Investigate using Guice to inject the correct compat object provided by
> compat plugins
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
