[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864985#comment-13864985
]
Liang Xie commented on HBASE-10294:
---
agree for above case. and we should remove very ca
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868027#comment-13868027
]
Sergey Shelukhin commented on HBASE-10294:
--
Yes, above is unnecessary. Patch? :)
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868111#comment-13868111
]
Sergey Shelukhin commented on HBASE-10294:
--
+1
> Some synchronization on Server
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868143#comment-13868143
]
Hadoop QA commented on HBASE-10294:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869273#comment-13869273
]
Hudson commented on HBASE-10294:
SUCCESS: Integrated in HBase-TRUNK #4809 (See
[https://
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870241#comment-13870241
]
Hudson commented on HBASE-10294:
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #52 (Se
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870729#comment-13870729
]
stack commented on HBASE-10294:
---
-1
Without the synchronization you increase the incidence
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870806#comment-13870806
]
Ted Yu commented on HBASE-10294:
At line 855, there is getOnlineServersList():
{code}
p
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870824#comment-13870824
]
Ted Yu commented on HBASE-10294:
Looks like getOnlineServersList() was introduced in HBAS
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870901#comment-13870901
]
stack commented on HBASE-10294:
---
bq. To see if I understand clearly, synchronization is nee
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870941#comment-13870941
]
Ted Yu commented on HBASE-10294:
The following FindBugs warning led me to look at getOnli
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870981#comment-13870981
]
Sergey Shelukhin commented on HBASE-10294:
--
Yeah, from description of keySet()
{
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870994#comment-13870994
]
stack commented on HBASE-10294:
---
Volunteering the justification for the change this far int
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870998#comment-13870998
]
Sergey Shelukhin commented on HBASE-10294:
--
Well, if the problem needs to be fix
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871005#comment-13871005
]
stack commented on HBASE-10294:
---
bq. The sync elsewhere is for iteration AND modification..
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871008#comment-13871008
]
Ted Yu commented on HBASE-10294:
Patch reverted to facilitate fixing ServerManager#online
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871162#comment-13871162
]
Sergey Shelukhin commented on HBASE-10294:
--
Btw, this sync was not around before
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871280#comment-13871280
]
Hudson commented on HBASE-10294:
FAILURE: Integrated in HBase-TRUNK #4818 (See
[https://
[
https://issues.apache.org/jira/browse/HBASE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871462#comment-13871462
]
Hudson commented on HBASE-10294:
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #53 (Se
19 matches
Mail list logo
