[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980493#comment-13980493
]
Mikhail Antonov commented on HBASE-10915:
-
Merging it with consensus infrastructu
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980489#comment-13980489
]
stack commented on HBASE-10915:
---
Where are we w/ this patch?
> Decouple region closing fro
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977837#comment-13977837
]
stack commented on HBASE-10915:
---
[~mantonov] That bit of code looks like a "just-in-case".
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977729#comment-13977729
]
Mikhail Antonov commented on HBASE-10915:
-
A note - ClosedRegionHandler on HM sid
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970442#comment-13970442
]
stack commented on HBASE-10915:
---
Retry by reuploading your patch. See what you get second
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970441#comment-13970441
]
stack commented on HBASE-10915:
---
[~mantonov] Yeah. Probably not you. Our tests have rotte
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970263#comment-13970263
]
Mikhail Antonov commented on HBASE-10915:
-
2014-04-15 20:29:02,357 INFO [pool-1-
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970066#comment-13970066
]
Hadoop QA commented on HBASE-10915:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969914#comment-13969914
]
Konstantin Boudnik commented on HBASE-10915:
A respectful nudge to reviewers:
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968741#comment-13968741
]
Mikhail Antonov commented on HBASE-10915:
-
Here is review request - https://revie
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966114#comment-13966114
]
Hadoop QA commented on HBASE-10915:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965874#comment-13965874
]
Mikhail Antonov commented on HBASE-10915:
-
I guess I shall give some explanation
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965837#comment-13965837
]
Ted Yu commented on HBASE-10915:
In that case it is fine keeping getConsensus() public.
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965832#comment-13965832
]
Mikhail Antonov commented on HBASE-10915:
-
[~yuzhih...@gmail.com] I would say tha
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965803#comment-13965803
]
Ted Yu commented on HBASE-10915:
This method in HRegionServer can be package private:
{co
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965112#comment-13965112
]
Hadoop QA commented on HBASE-10915:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964911#comment-13964911
]
Mikhail Antonov commented on HBASE-10915:
-
Attached patch to fix test (broken in
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964907#comment-13964907
]
Hadoop QA commented on HBASE-10915:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964750#comment-13964750
]
Mikhail Antonov commented on HBASE-10915:
-
That's HBASE-10813 where the KeeperExc
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964746#comment-13964746
]
Mikhail Antonov commented on HBASE-10915:
-
Yeah, i just removed the annotations b
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964739#comment-13964739
]
Ted Yu commented on HBASE-10915:
There was compilation error:
{code}
[ERROR] Failed to ex
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964652#comment-13964652
]
Hadoop QA commented on HBASE-10915:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964108#comment-13964108
]
Ted Yu commented on HBASE-10915:
When @InterfaceAudience.Private is present, the Unstable
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963965#comment-13963965
]
Hadoop QA commented on HBASE-10915:
---
{color:green}+1 overall{color}. Here are the resu
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963863#comment-13963863
]
Mikhail Antonov commented on HBASE-10915:
-
I assume that most of consensus interf
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963759#comment-13963759
]
Ted Yu commented on HBASE-10915:
{code}
+public class ConsensusFactory {
{code}
Would Con
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962738#comment-13962738
]
Hadoop QA commented on HBASE-10915:
---
{color:green}+1 overall{color}. Here are the resu
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962699#comment-13962699
]
Mikhail Antonov commented on HBASE-10915:
-
Oh yeah, both such zk fields are optio
[
https://issues.apache.org/jira/browse/HBASE-10915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13962640#comment-13962640
]
stack commented on HBASE-10915:
---
I owe a closer review but on a quick skim, it is looking g
29 matches
Mail list logo
