[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134442#comment-14134442
]
Hudson commented on HBASE-11136:
FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #494 (Se
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134404#comment-14134404
]
Hudson commented on HBASE-11136:
FAILURE: Integrated in HBase-0.98 #519 (See
[https://bu
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134233#comment-14134233
]
Hudson commented on HBASE-11136:
FAILURE: Integrated in HBase-TRUNK #5506 (See
[https://
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134194#comment-14134194
]
Hadoop QA commented on HBASE-11136:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134187#comment-14134187
]
Jerry He commented on HBASE-11136:
--
Hi, [~tedyu], [~apurtell]
I attached a 0.98-v3 patc
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134121#comment-14134121
]
Andrew Purtell commented on HBASE-11136:
bq. 0.98 needs separate patch.
Ok, I wi
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134120#comment-14134120
]
Hudson commented on HBASE-11136:
FAILURE: Integrated in HBase-1.0 #185 (See
[https://bui
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134074#comment-14134074
]
Ted Yu commented on HBASE-11136:
Integrated to branch-1 and master.
0.98 needs separate
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134054#comment-14134054
]
Andrew Purtell commented on HBASE-11136:
+1 patch v3, looks good
Looks good for 0
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133579#comment-14133579
]
Jerry He commented on HBASE-11136:
--
The test failures don't see to be related to the pat
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133539#comment-14133539
]
Ted Yu commented on HBASE-11136:
[~apurtell]:
Do you have other comments based on patch v
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133477#comment-14133477
]
Hadoop QA commented on HBASE-11136:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133442#comment-14133442
]
Hadoop QA commented on HBASE-11136:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133385#comment-14133385
]
Jerry He commented on HBASE-11136:
--
Hi, [~yuzhih...@gmail.com]
Thanks! Corrected with t
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133372#comment-14133372
]
Ted Yu commented on HBASE-11136:
lgtm
Minor:
{code}
+ * @param ctx An instance of Regio
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133347#comment-14133347
]
Jerry He commented on HBASE-11136:
--
Hadoop QA is not triggered.
Here is my local 'mvn te
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133080#comment-14133080
]
Jerry He commented on HBASE-11136:
--
Attached v2-patch that rebased with the latest and a
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127979#comment-14127979
]
Jerry He commented on HBASE-11136:
--
Hi, [~apurtell]
The patch is old. I will rebase and
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127934#comment-14127934
]
Andrew Purtell commented on HBASE-11136:
Also, please avoid copy-paste in the new
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127912#comment-14127912
]
Andrew Purtell commented on HBASE-11136:
ADMIN privilege makes more sense to me (
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127911#comment-14127911
]
Andrew Purtell commented on HBASE-11136:
Don't add this logging (there's a mis-sp
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126541#comment-14126541
]
Enis Soztutar commented on HBASE-11136:
---
This looks important to fix.
postRollWAL
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992503#comment-13992503
]
Jerry He commented on HBASE-11136:
--
Probably global ADMIN privilege should be required?
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995572#comment-13995572
]
Hadoop QA commented on HBASE-11136:
---
{color:red}-1 overall{color}. Here are the result
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995934#comment-13995934
]
Ted Yu commented on HBASE-11136:
Would adding Permission.Action.CREATE give less surprise
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996091#comment-13996091
]
Jerry He commented on HBASE-11136:
--
Hi, Ted
I don't have strong preference either way.
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996579#comment-13996579
]
Ted Yu commented on HBASE-11136:
[~apurtell]:
Can you take a look ?
> Add permission che
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995333#comment-13995333
]
Jerry He commented on HBASE-11136:
--
There is no use for postRollWALWriter() now.
Is it c
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995578#comment-13995578
]
Jerry He commented on HBASE-11136:
--
Hi, Ted
Good question. I am not very clear regardin
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995314#comment-13995314
]
Ted Yu commented on HBASE-11136:
What's the purpose of adding postRollWALWriter() hook ?
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995280#comment-13995280
]
Jerry He commented on HBASE-11136:
--
Attached a patch.
The patch also includes a missing
[
https://issues.apache.org/jira/browse/HBASE-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995486#comment-13995486
]
Ted Yu commented on HBASE-11136:
{code}
+requirePermission("preRollLogWriter", Permis
32 matches
Mail list logo