[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103220#comment-14103220 ] Hudson commented on HBASE-11657: SUCCESS: Integrated in HBase-TRUNK #5412 (See [https://

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103145#comment-14103145 ] Hudson commented on HBASE-11657: FAILURE: Integrated in HBase-1.0 #113 (See [https://bui

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-19 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103005#comment-14103005 ] Enis Soztutar commented on HBASE-11657: --- +1. May the force be with you. > Put HTa

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102613#comment-14102613 ] stack commented on HBASE-11657: --- +1 on v6 (Waiting on Pope @enis to give his blessing befor

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-19 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102569#comment-14102569 ] stack commented on HBASE-11657: --- bq. For RegionLocations, we may need an immutable version.

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-18 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101532#comment-14101532 ] Enis Soztutar commented on HBASE-11657: --- bq. Sorry to open up this can of worms, bu

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-18 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101189#comment-14101189 ] Carter commented on HBASE-11657: I mainly wanted to make sure that the same person who ma

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-18 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101086#comment-14101086 ] Enis Soztutar commented on HBASE-11657: --- I've made HRL private in an earlier patch

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-18 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100876#comment-14100876 ] Carter commented on HBASE-11657: That would certainly solve the problem with {{TableInput

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-14 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097745#comment-14097745 ] Enis Soztutar commented on HBASE-11657: --- bq. How should the interfaces and MapReduc

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-14 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097731#comment-14097731 ] Carter commented on HBASE-11657: I'll add Closeable to the interface, makes sense. While

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-14 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097215#comment-14097215 ] Nick Dimiduk commented on HBASE-11657: -- bq. Should RegionLocator extend Closeable?

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-14 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097209#comment-14097209 ] Nick Dimiduk commented on HBASE-11657: -- The MapReduce classes are considered "intern

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-14 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096975#comment-14096975 ] Carter commented on HBASE-11657: How should the interfaces and MapReduce play together?

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096609#comment-14096609 ] stack commented on HBASE-11657: --- Yeah, we've been trying to shutdown notions of 'region' sh

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-13 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096178#comment-14096178 ] Enis Soztutar commented on HBASE-11657: --- A couple of comments: - RegionLocator ->

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-13 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095812#comment-14095812 ] Carter commented on HBASE-11657: The three test failures seem unrelated to the patch. I

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094194#comment-14094194 ] Hadoop QA commented on HBASE-11657: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-11 Thread Enis Soztutar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093602#comment-14093602 ] Enis Soztutar commented on HBASE-11657: --- Carter, I really like this jira. Let me ta

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-11 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092970#comment-14092970 ] Carter commented on HBASE-11657: Please take another look. For the managed connection ch

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091679#comment-14091679 ] Hadoop QA commented on HBASE-11657: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-08 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091639#comment-14091639 ] stack commented on HBASE-11657: --- It makes sense to me going to a RegionLocator Interface to

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087792#comment-14087792 ] Hadoop QA commented on HBASE-11657: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086942#comment-14086942 ] Hadoop QA commented on HBASE-11657: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-05 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086853#comment-14086853 ] Mikhail Antonov commented on HBASE-11657: - Yes, the reasoning about most used vs.

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-05 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086790#comment-14086790 ] Carter commented on HBASE-11657: Not sure I agree on having only one method. I agree wit

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-05 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086653#comment-14086653 ] Mikhail Antonov commented on HBASE-11657: - @stack yeah, I was just thinking as we

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086624#comment-14086624 ] stack commented on HBASE-11657: --- [~mantonov] We have to preserve current api if we are to c

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-05 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086617#comment-14086617 ] Mikhail Antonov commented on HBASE-11657: - Thanks [~carterpage] - few comments:

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-05 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086430#comment-14086430 ] Carter commented on HBASE-11657: No deltas between tests I ran on master and the patch.

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086383#comment-14086383 ] Hadoop QA commented on HBASE-11657: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085302#comment-14085302 ] Mikhail Antonov commented on HBASE-11657: - Maybe name it RegionLocator or RegionL

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085189#comment-14085189 ] Carter commented on HBASE-11657: Two more questions before I start: # There is an existi

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085139#comment-14085139 ] Mikhail Antonov commented on HBASE-11657: - [~carterpage] I think RegionLocation i

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085127#comment-14085127 ] stack commented on HBASE-11657: --- +1 on RegionLocation. A fat Region Interface could impleme

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085111#comment-14085111 ] Carter commented on HBASE-11657: How about I start with the first change -- moving region

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085094#comment-14085094 ] stack commented on HBASE-11657: --- [~carterpage] Now you would expand scope of the new Interf

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Carter (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084937#comment-14084937 ] Carter commented on HBASE-11657: Okay, these are the region-related methods I spot in Adm

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084929#comment-14084929 ] stack commented on HBASE-11657: --- Suggest keeping narrow scope for this new Interface additi

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084920#comment-14084920 ] Mikhail Antonov commented on HBASE-11657: - As yet another straw man..methods like

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084909#comment-14084909 ] Andrew Purtell commented on HBASE-11657: {{LocationServices}} sounds good, so did

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084768#comment-14084768 ] Lars Hofhansl commented on HBASE-11657: --- We had discussed adding these to HTableInt

[jira] [Commented] (HBASE-11657) Put HTable region methods in an interface

2014-08-04 Thread Nick Dimiduk (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-11657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084756#comment-14084756 ] Nick Dimiduk commented on HBASE-11657: -- For another straw man, how about extracting