[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14244621#comment-14244621
]
Jerry He commented on HBASE-12373:
--
Hi, [~stack]
Attached a 0.98-v6 patch.
Ran UT
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245001#comment-14245001
]
stack commented on HBASE-12373:
---
Applied to 0.98. Thanks for the patch [~jerryhe]
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245108#comment-14245108
]
Hudson commented on HBASE-12373:
FAILURE: Integrated in HBase-0.98 #738 (See
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245143#comment-14245143
]
Hudson commented on HBASE-12373:
SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #705
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242416#comment-14242416
]
Anoop Sam John commented on HBASE-12373:
+1
Minor comments on javadoc
Retrieve
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243264#comment-14243264
]
Jerry He commented on HBASE-12373:
--
Attached v6 to address the minor comment above.
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243438#comment-14243438
]
Hadoop QA commented on HBASE-12373:
---
{color:green}+1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243518#comment-14243518
]
Hudson commented on HBASE-12373:
SUCCESS: Integrated in HBase-1.0 #575 (See
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243561#comment-14243561
]
Hudson commented on HBASE-12373:
FAILURE: Integrated in HBase-TRUNK #5911 (See
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241476#comment-14241476
]
stack commented on HBASE-12373:
---
[~ram_krish] and [~anoop.hbase] Any chance of a last
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242071#comment-14242071
]
Jerry He commented on HBASE-12373:
--
The new file list_labels.rb has license header.
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242216#comment-14242216
]
Anoop Sam John commented on HBASE-12373:
Sorry for the delay.. I will look at the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238764#comment-14238764
]
Hadoop QA commented on HBASE-12373:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239023#comment-14239023
]
Hadoop QA commented on HBASE-12373:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235922#comment-14235922
]
Jerry He commented on HBASE-12373:
--
Thanks [~apurtell].
Attached v4 that adds regex
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236095#comment-14236095
]
Hadoop QA commented on HBASE-12373:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236392#comment-14236392
]
Jerry He commented on HBASE-12373:
--
Will fix the two long lines.
Are we ok overall this
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223529#comment-14223529
]
Andrew Purtell commented on HBASE-12373:
Better than before [~jerryhe]
Provide
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222536#comment-14222536
]
Jerry He commented on HBASE-12373:
--
How about we proceed with the following?
We will
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14221035#comment-14221035
]
Anoop Sam John commented on HBASE-12373:
As it is single region the ordinal
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14218669#comment-14218669
]
Jerry He commented on HBASE-12373:
--
Hi, [~apurtell]
Thanks for the comment. All are
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14219052#comment-14219052
]
Jerry He commented on HBASE-12373:
--
We explicitly restrict to only one labels region
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215968#comment-14215968
]
Anoop Sam John commented on HBASE-12373:
+1
What is these new checkstyle
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14216697#comment-14216697
]
Jerry He commented on HBASE-12373:
--
Hi, [~anoop.hbase]
The checkstyle comment seem to
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14217202#comment-14217202
]
Andrew Purtell commented on HBASE-12373:
+1 in general for the change for 0.98
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215077#comment-14215077
]
Jerry He commented on HBASE-12373:
--
Hi, [~ram_krish]
Ok.
Attached v3 which removed the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215168#comment-14215168
]
Hadoop QA commented on HBASE-12373:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14214330#comment-14214330
]
ramkrishna.s.vasudevan commented on HBASE-12373:
Looks good. Should we
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213684#comment-14213684
]
Anoop Sam John commented on HBASE-12373:
Why listLabels() impl in
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213771#comment-14213771
]
Jerry He commented on HBASE-12373:
--
Hi, [~anoop.hbase]
I attached v2 which added the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213800#comment-14213800
]
Hadoop QA commented on HBASE-12373:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213296#comment-14213296
]
Hadoop QA commented on HBASE-12373:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188173#comment-14188173
]
Anoop Sam John commented on HBASE-12373:
It should be allowed only for a user who
[
https://issues.apache.org/jira/browse/HBASE-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188548#comment-14188548
]
Jerry He commented on HBASE-12373:
--
bq. It should be allowed only for a user who is
34 matches
Mail list logo
