[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2017-12-07 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283110#comment-16283110 ] Anoop Sam John commented on HBASE-13819: U mean at the NIO level right? Ya bette

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2017-12-07 Thread huaxiang sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282372#comment-16282372 ] huaxiang sun commented on HBASE-13819: -- Thanks [~anoop.hbase] for explaining the BBP

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2017-12-06 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281355#comment-16281355 ] Anoop Sam John commented on HBASE-13819: So u mean the NIO wont keep that DBB in

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2017-12-06 Thread huaxiang sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280599#comment-16280599 ] huaxiang sun commented on HBASE-13819: -- Thanks [~anoop.hbase]. With JDK-8147468, in

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2017-12-06 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280007#comment-16280007 ] Anoop Sam John commented on HBASE-13819: Ya reqs wont use the BBPool.. But the re

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2017-12-05 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279698#comment-16279698 ] ramkrishna.s.vasudevan commented on HBASE-13819: Just one question now -

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2017-12-05 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279648#comment-16279648 ] Anoop Sam John commented on HBASE-13819: The Direct memory (DBB) we allocate for

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2017-12-05 Thread huaxiang sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279306#comment-16279306 ] huaxiang sun commented on HBASE-13819: -- Hi [~anoop.hbase], I am reading the patch an

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209793#comment-15209793 ] stack commented on HBASE-13819: --- New JIRA! This one is resolved (smlle) [~anoop.hbase] > M

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209792#comment-15209792 ] stack commented on HBASE-13819: --- bq. Client side can do? Server has to do it. In this case

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209768#comment-15209768 ] stack commented on HBASE-13819: --- bq, .what do you think ? Thinking on it, a manual con

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209757#comment-15209757 ] Anoop Sam John commented on HBASE-13819: Ya am not saying this on heap create is

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209749#comment-15209749 ] deepankar commented on HBASE-13819: --- I totally agree with your idea, but I think practi

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209739#comment-15209739 ] deepankar commented on HBASE-13819: --- I agree with you but what I feel is in the ideal s

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209736#comment-15209736 ] deepankar commented on HBASE-13819: --- bq. What you think of Anoop's idea of the BB being

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209732#comment-15209732 ] Anoop Sam John commented on HBASE-13819: Its not case of leak Stack.. Ya I agr

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209439#comment-15209439 ] stack commented on HBASE-13819: --- What would you like [~deenarang]? The burst to show onheap

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209432#comment-15209432 ] stack commented on HBASE-13819: --- We do seem to be bottlenecking on responding. I'm not sure

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209427#comment-15209427 ] stack commented on HBASE-13819: --- Good to hear you don't think there leaking going on. bq.

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209425#comment-15209425 ] deepankar commented on HBASE-13819: --- Attached image of the metric over time. we are run

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209414#comment-15209414 ] deepankar commented on HBASE-13819: --- bq. In description above though, talk is of Respon

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209412#comment-15209412 ] stack commented on HBASE-13819: --- bq. What Anoop Sam John said is correct, in our case avg r

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209409#comment-15209409 ] deepankar commented on HBASE-13819: --- bq. Which Q we talking? The is config to put bound

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209401#comment-15209401 ] deepankar commented on HBASE-13819: --- bq. Because we are not returning BB to the pool? T

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209398#comment-15209398 ] stack commented on HBASE-13819: --- The BBBP is configurable. You can set upper bound on BBBP

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209388#comment-15209388 ] stack commented on HBASE-13819: --- Which Q we talking? The is config to put bounds on the ca

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209371#comment-15209371 ] stack commented on HBASE-13819: --- bq. We recently pulled this patch internally and are seein

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208009#comment-15208009 ] deepankar commented on HBASE-13819: --- What [~anoop.hbase] said is correct, in our case a

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-23 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207999#comment-15207999 ] Anoop Sam John commented on HBASE-13819: 5 GB max direct memory is what given I b

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-22 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207974#comment-15207974 ] ramkrishna.s.vasudevan commented on HBASE-13819: How much is the Directme

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-22 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207917#comment-15207917 ] Anoop Sam John commented on HBASE-13819: Ya we had an offline discuss abt this is

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2016-03-22 Thread deepankar (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207822#comment-15207822 ] deepankar commented on HBASE-13819: --- Hi, We recently pulled this patch internally and

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-10-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954605#comment-14954605 ] Hudson commented on HBASE-13819: FAILURE: Integrated in HBase-TRUNK #6900 (See [https://

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-10-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954445#comment-14954445 ] Hudson commented on HBASE-13819: FAILURE: Integrated in HBase-1.3-IT #229 (See [https://

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-10-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954412#comment-14954412 ] Hudson commented on HBASE-13819: FAILURE: Integrated in HBase-1.3 #255 (See [https://bui

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-10-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946078#comment-14946078 ] Hadoop QA commented on HBASE-13819: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-10-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939761#comment-14939761 ] Hadoop QA commented on HBASE-13819: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934835#comment-14934835 ] Hadoop QA commented on HBASE-13819: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909417#comment-14909417 ] stack commented on HBASE-13819: --- bq. We can do in a later issue after tests. Ok Stack? Of

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909325#comment-14909325 ] Anoop Sam John commented on HBASE-13819: bq.We don't want to do offheap on client

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-26 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909305#comment-14909305 ] Anoop Sam John commented on HBASE-13819: Yes these DBBs are any way allocated but

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909157#comment-14909157 ] stack commented on HBASE-13819: --- bq. May be that will be a surprise for changes in 1.x vers

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909002#comment-14909002 ] stack commented on HBASE-13819: --- bq. So in client side we will continue with on heap only.

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-25 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908995#comment-14908995 ] Anoop Sam John commented on HBASE-13819: Oh yes. We might be using this pool for

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908390#comment-14908390 ] stack commented on HBASE-13819: --- We can do the above suggestion in another patch when the p

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908236#comment-14908236 ] stack commented on HBASE-13819: --- One thought [~anoop.hbase] is that rather than always make

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-24 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906538#comment-14906538 ] ramkrishna.s.vasudevan commented on HBASE-13819: +1. This was done in ou

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-24 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906514#comment-14906514 ] stack commented on HBASE-13819: --- +1 This is [~anoop.hbase] following up on findings from H

[jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a DirectByteBuffer

2015-09-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906182#comment-14906182 ] Hadoop QA commented on HBASE-13819: --- {color:red}-1 overall{color}. Here are the result